Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC 20200304 #38

Merged
merged 10 commits into from
Mar 12, 2020
Merged

IC 20200304 #38

merged 10 commits into from
Mar 12, 2020

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Mar 10, 2020

Describe the contribution
Integration candidate 20200304
Fixes #23, #27, #34, #36, and #39

See PR #35 for more details

Testing performed
CI Testing only

Expected behavior changes
#23 - Use OSAL socket API instead of BSD sockets

#27 - Drop PDU introspection code

#34 - Update command and telemetry logic to match other modules and recommended conventions

#36 - Collect globals as a single top-level global structure

#39 - ci again runs with clang-format

System(s) tested on
OS: Ubuntu-Bionic

Additional context
See PR #35 and #40 for more details

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey- Vantage Systems, Inc.
Gerardo E. Cruz-Ortiz - NASA/GSFC

jphickey and others added 6 commits February 7, 2020 20:37
This code has numerous quality issues and has repeatedly been
a maintenance problem, and also is of questionable usefulness.

It was agreed in the CCB to drop this feature.
This removes the need to use BSD socket calls directly within CI_LAB
Make the patterns in CI better match the patterns used
in other modules (CFE core, Sample App, etc)

- Separate each command into a separate handler function
- Each command handler accepts a const pointer to the full message
- Put Telemetry payload into a separate "Payload" sub-structure
- Use naming conventions defined in conventions document

Note the payload name changes only affect the FSW internal
usage, the payload format for the ground system is not changed.
Add a global structure called "CI_LAB_Global" for all globals, getting
them out of the global namespace.  All other identifiers that remain
in the global namespace should be prefixed consistently with CI_LAB_
to match the name of the app.
@astrogeco astrogeco merged commit 44d8fde into master Mar 12, 2020
@astrogeco astrogeco deleted the ic-20200304 branch March 13, 2020 14:03
@skliper skliper added this to the 2.4.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants